[
https://issues.apache.org/jira/browse/TS-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172443#comment-15172443
]
ASF GitHub Bot commented on TS-4231:
------------------------------------
GitHub user dmorilha opened a pull request:
https://github.com/apache/trafficserver/pull/506
[TS-4231] getting rid of TSActionDone useless call
@bryancall @zwoop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmorilha/trafficserver ts4231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit 03e6a5282376b71a260cde7c02e4fb460af3aaac
Author: Daniel Vitor Morilha <[email protected]>
Date: 2016-02-29T19:26:36Z
[TS-4231] getting rid of TSActionDone useless call
----
> Coverity issues in inlined plugin: CID 1352204 and CID 1352203
> --------------------------------------------------------------
>
> Key: TS-4231
> URL: https://issues.apache.org/jira/browse/TS-4231
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Daniel Vitor Morilha
> Fix For: 6.2.0
>
>
> {code}
> ** CID 1352204: Incorrect expression (USELESS_CALL)
> ________________________________________________________________________________________________________
> *** CID 1352204: Incorrect expression (USELESS_CALL)
> /plugins/experimental/inliner/ts.cc: 175 in
> ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
> 169 case TS_EVENT_TIMEOUT:
> 170 TSError("[" PLUGIN_TAG "] TS_EVENT_TIMEOUT from producer");
> 171
> 172 handle_error:
> 173 operation.close();
> 174 assert(operation.action_ != NULL);
> CID 1352204: Incorrect expression (USELESS_CALL)
> Calling "TSActionDone(operation.action_)" is only useful for its return
> value, which is ignored.
> 175 TSActionDone(operation.action_);
> 176 operation.action_ = NULL;
> 177 /*
> 178 TSContDataSet(c, NULL);
> 179 delete p;
> 180 */
> ** CID 1352203: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/inliner/ts.cc: 175 in
> ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
> ________________________________________________________________________________________________________
> *** CID 1352203: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/inliner/ts.cc: 175 in
> ats::io::WriteOperation::Handle(tsapi_cont *, TSEvent, void *)()
> 169 case TS_EVENT_TIMEOUT:
> 170 TSError("[" PLUGIN_TAG "] TS_EVENT_TIMEOUT from producer");
> 171
> 172 handle_error:
> 173 operation.close();
> 174 assert(operation.action_ != NULL);
> CID 1352203: Error handling issues (CHECKED_RETURN)
> Calling "TSActionDone" without checking return value (as is done elsewhere
> 8 out of 9 times).
> 175 TSActionDone(operation.action_);
> 176 operation.action_ = NULL;
> 177 /*
> 178 TSContDataSet(c, NULL);
> 179 delete p;
> 180 */
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
