[ 
https://issues.apache.org/jira/browse/TS-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175017#comment-15175017
 ] 

ASF GitHub Bot commented on TS-4065:
------------------------------------

Github user zwoop commented on the pull request:

    https://github.com/apache/trafficserver/pull/488#issuecomment-191056670
  
    The latest patch looks good to me, +1.
    
    Meera: In addition, can you make another PR to fix the documentation for 
the metrics you found that are marked wrongly in the documentations?


> change metrics to counters where appropriate
> --------------------------------------------
>
>                 Key: TS-4065
>                 URL: https://issues.apache.org/jira/browse/TS-4065
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Management API, Metrics
>            Reporter: James Peach
>            Assignee: Meera Mosale Nataraja
>             Fix For: sometime
>
>
> In {{mgmt/RecordsConfig.cc}} almost all the metrics are registered as 
> {{RECT_INT}} even though many (most?) of them have counter semantics. We 
> should register the counters as {{RECT_COUNTER}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to