[
https://issues.apache.org/jira/browse/TS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187862#comment-15187862
]
ASF subversion and git services commented on TS-1775:
-----------------------------------------------------
Commit d95d9e84e82e7752c0348cfa17a851f4bc914061 in trafficserver's branch
refs/heads/master from [~amc]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d95d9e8 ]
TS-1775: General hrtime cleanup.
This close #515.
> Cleanup of ink_hrtime.{cc,h}
> ----------------------------
>
> Key: TS-1775
> URL: https://issues.apache.org/jira/browse/TS-1775
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Labels: newbie
> Fix For: 6.2.0
>
>
> A few things comes to mind:
> 1) Why do we have a NEED_HRTIME define? It's always on as far as I can tell,
> and I can't imagine there's a reason to not have it on (it'd completely break
> like everything, in fact it would fail to compile since gethrtime() doesn't
> exist?).
> 2) We should eliminate the USE_TIME_STAMP_COUNTER_HRTIME define, and the code
> that implements our own TSC code. Modern Unix flavors implements this already
> in various way (e.g. glibc's gettimeofday() wrapper has a TSC user space
> implementation).
> 3) On FreeBSD, jpeach points out that CLOCK_REALTIME is probably not the
> optimal way to use clock_gettime(). He suggest using CLOCK_REALTIME_FAST or
> CLOCK_MONOTONIC_FAST which is similar to the optimizations done with TSC for
> gettimeofday() on linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
