[
https://issues.apache.org/jira/browse/TS-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207853#comment-15207853
]
ASF GitHub Bot commented on TS-3607:
------------------------------------
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/210#discussion_r57108812
--- Diff: plugins/experimental/ats_pagespeed/Makefile.am ---
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(top_srcdir)/build/plugins.mk
+
+if ATS_PAGESPEED_LINUX
+ os_name = linux
+else
+ os_name = unknown_os
+endif
+
+if ATS_PAGESPEED_X86_64
+ arch_name = x64
+else
+ arch_name = ia32
+endif
+
--- End diff --
You don't need to do this. In ``configure.ac`` changes, just ``AC_SUBST``
the values. Then later on you can use ``@ATS_PAGESPEED_OS@`` and
``@ATS_PAGESPEED_ARCH@``.
> ats_pagespeed make error
> ------------------------
>
> Key: TS-3607
> URL: https://issues.apache.org/jira/browse/TS-3607
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Sebastian Pesman
> Assignee: Otto van der Schaaf
> Fix For: sometime
>
>
> When compiling ats_pagespeed from the current master git
> /tmp/trafficserver/plugins/experimental/ats_pagespeed the make process
> results in an error.
> The error:
> ats_pagespeed.cc: In function 'void ats_transform_init(TSCont,
> TransformCtx*)':
> ats_pagespeed.cc:485:109: error: 'INT64_MAX' was not declared in this scope
> ctx->downstream_vio = TSVConnWrite(downstream_conn, contp,
> TSIOBufferReaderAlloc(ctx->downstream_buffer), INT64_MAX);
>
> ^
> make: *** [ats_pagespeed.so] Error 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
