[
https://issues.apache.org/jira/browse/TS-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228463#comment-15228463
]
ASF GitHub Bot commented on TS-4321:
------------------------------------
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r58726866
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1007,14 +1007,18 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
DebugHttp2Stream(ua_session, stream->get_id(), "Send HEADERS frame");
- http2_convert_header_from_1_1_to_2(resp_header);
- buf_len = resp_header->length_get() * 2; // Make it double just in case
+ HTTPHdr *h2_hdr = http2_generate_h2_header_from_1_1(resp_header);
--- End diff --
I think we should probably avoid the malloc by using an out parameter for
the HTTP2 copy.
> H2 truncates certain contents on master
> ---------------------------------------
>
> Key: TS-4321
> URL: https://issues.apache.org/jira/browse/TS-4321
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Leif Hedstrom
> Assignee: Masakazu Kitajo
> Priority: Critical
> Labels: A, regression
> Fix For: 6.2.0
>
>
> This seems to be a regression, since it does not happen on 6.1.x. I haven't
> dug deeper into it, but in the case I found, ATS closes the stream after 2
> data frames (8k + a few bytes), where it really needs to send about 27KB.
> I've reverted my server to 6.1.x for now, but I'll see if I can find
> something to reproduce it on e.g. docs.trafficserver.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
