[
https://issues.apache.org/jira/browse/TS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239948#comment-15239948
]
ASF GitHub Bot commented on TS-4072:
------------------------------------
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/568
TS-4072 Diagnostic log rolling races
This patch prevents race conditions when a diagnostic log rolls. The patch
is a little longer than I had hoped for because of error handling conditions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-4072
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #568
----
commit ed30d422efd71333722f4124d5eebeae037a9750
Author: Daniel Xu <[email protected]>
Date: 2016-04-13T19:34:34Z
TS-4072 Diagnostic log rolling races
Use preexisting mutex to prevent race condition when rotating
diags_log, stdout_log, and stderr_log.
commit 797553e67140349d8f49b7f0840e397087fd8047
Author: Daniel Xu <[email protected]>
Date: 2016-04-13T19:35:09Z
Improve diagnostic logs logging statements
----
> Diagnostic log rolling races
> ----------------------------
>
> Key: TS-4072
> URL: https://issues.apache.org/jira/browse/TS-4072
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: James Peach
> Assignee: Daniel Xu
> Fix For: 6.2.0
>
>
> When diagnostic logs are rolled, {{Diags::diags_log}} is deleted and replaced
> with a new log object. Since the global {{diags}} points to a a single
> {{Diags}} object there is nothing to prevent a different thread logging
> through this object at the time it is deleted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
