[
https://issues.apache.org/jira/browse/TS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257850#comment-15257850
]
ASF GitHub Bot commented on TS-4328:
------------------------------------
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/554#issuecomment-214693606
The problem is that you are trying to "mix" the internals of a completely
independent/different feature to use for an unrelated/unintended purposes. This
sets a bad precedent and makes the code harder to maintain.
You are looking at one specific example where it seems to be conveniently
doing what you need "right now" - but, just bcoz it seems to be satisfying the
needs right now doesn't mean it will continue to do so in the future, since
milestones is a different feature/function intended to do completely different
things. If tomorrow someone changes milestone implementation which is not
entirely unlikely, it affects the rest of the code that depends on it so
tightly because of its usage as "more" than milestones. Again, you might argue
that when changing milestones one could also go ahead and change the rest of
the code that "depends" on it. But, you now probably see the issue there? Think
of people following the precedent set and start to randomly use milestones all
over the place for various unrelated purposes. Milestones feature is no longer
doing just milestones :)
> Connect_retries re-connects even if request made it to origin (TS-3440 repeat)
> ------------------------------------------------------------------------------
>
> Key: TS-4328
> URL: https://issues.apache.org/jira/browse/TS-4328
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Thomas Jackson
> Assignee: Thomas Jackson
> Fix For: sometime
>
>
> I'm creating another issue as the root bug for TS-3440 can still be
> reproduced if the origin is extremely slow (but no returns no error response).
> I've opened a PR (https://github.com/apache/trafficserver/pull/554) which
> reverts the original patch and instead checks if any bytes where sent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
