[ 
https://issues.apache.org/jira/browse/TS-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269982#comment-15269982
 ] 

Susan Hinrichs commented on TS-3485:
------------------------------------

You are right.  I placed the logic in Http2ClientSession::new_connection 
because that is were I was running into permission problems.  But it makes more 
sense to make the IP level check in the Accept object before the session object 
is created.  I'm testing the change now and will issue a PR assuming that works 
out.

The ACL logic is still split because the non-IP checks are performed in 
HttpTransact.

> We should honor ip_allow.config ACLs for HTTP/2 streams
> -------------------------------------------------------
>
>                 Key: TS-3485
>                 URL: https://issues.apache.org/jira/browse/TS-3485
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Leif Hedstrom
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>
> From the comments:
> {code}
> // XXX we need to refactor the ACL checks from HttpSessionAccept so that we 
> can invoke them here, and also in
> // the SPDY protocol layer ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to