[
https://issues.apache.org/jira/browse/TS-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279546#comment-15279546
]
ASF GitHub Bot commented on TS-4432:
------------------------------------
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/625#issuecomment-218362265
int
UnixNetVConnection::connectUp(EThread *t, int fd)
{
int res;
thread = t;
if (check_net_throttle(CONNECT, submit_time)) {
check_throttle_warning();
action_.continuation->handleEvent(NET_EVENT_OPEN_FAILED, (void
*)-ENET_THROTTLING);
free(t); ------> free(t) has been called before the connectUp()
return CONNECT_FAILURE to TSVConnFdCreate
return CONNECT_FAILURE;
}
> TSVConnFdCreate, double free on connectUp failure
> -------------------------------------------------
>
> Key: TS-4432
> URL: https://issues.apache.org/jira/browse/TS-4432
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Oknet Xu
> Fix For: 7.0.0
>
>
> {{vc->free()}} has been called when connectUp return {CONNECT_FAILURE}.
> but {{TSVConnFdCreate}} call {{vc->free()}} again on {{NOT}}
> {{CONNECT_SUCCESS}}.
> {code}
> if (vc->connectUp(this_ehtread(), fd) != CONNECT_SUCCESS) {
> vc->free(this_ethread());
> return NULL;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
