[
https://issues.apache.org/jira/browse/TS-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287263#comment-15287263
]
ASF GitHub Bot commented on TS-4440:
------------------------------------
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/636#discussion_r63581211
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3460,7 +3460,7 @@ HttpTransact::HandleStatPage(State *s)
s->hdr_info.client_response.value_set(MIME_FIELD_CONTENT_TYPE,
MIME_LEN_CONTENT_TYPE, s->internal_msg_buffer_type, len);
}
} else {
- s->hdr_info.client_response.value_set(MIME_FIELD_CONTENT_TYPE,
MIME_LEN_CONTENT_TYPE, "text/plain", 9);
+ s->hdr_info.client_response.value_set(MIME_FIELD_CONTENT_TYPE,
MIME_LEN_CONTENT_TYPE, "text/plain", 10);
--- End diff --
@jpeach I've created [TS-4451|
https://issues.apache.org/jira/browse/TS-4451] for the longer-term fix for all
of these magic numbers. For now I'm going to merge this in as this fixes it and
matches "style" in its context.
> ATS' missing StatsPages have incorrect content-type
> ---------------------------------------------------
>
> Key: TS-4440
> URL: https://issues.apache.org/jira/browse/TS-4440
> Project: Traffic Server
> Issue Type: Bug
> Components: Manager
> Reporter: Thomas Jackson
> Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> If you curl a stats page that doesn't exist anymore:
> {code}
> jacksontj@Thomas-PC trafficserver]$ curl -v localhost:8080/_stats/
> * Trying ::1...
> * connect to ::1 port 8080 failed: Connection refused
> * Trying 127.0.0.1...
> * Connected to localhost (127.0.0.1) port 8080 (#0)
> > GET /_stats/ HTTP/1.1
> > Host: localhost:8080
> > User-Agent: curl/7.43.0
> > Accept: */*
> >
> < HTTP/1.1 400 Bad Request
> < Date: Fri, 13 May 2016 14:55:58 GMT
> < Connection: close
> < Server: ATS/7.0.0
> < Content-Length: 0
> < Content-Type: text/plai
> <
> * Closing connection 0
> {code}
> Note that the content-type is cut off.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
