[ 
https://issues.apache.org/jira/browse/TS-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297253#comment-15297253
 ] 

ASF subversion and git services commented on TS-4366:
-----------------------------------------------------

Commit 77bd40ba19f29b11873c1709485b64840d137dde in trafficserver's branch 
refs/heads/master from [~gancho]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=77bd40b ]

TS-4366 Uninitialized stack value used in mp4 plugin

It is possible that there are cases where IOBufferReaderCopy() does not modify
the input buffer (copy 0 bytes) which leaves the buffer uninitialized which is
undesirable since the buffers are always allocated on the stack.

Addressed it in one of 2 ways:
(1) memset(buffer, 0, sizeof(buffer)) or
(2) check IOBufferReaderCopy() return value and handle accordingly.

These changes are meant to only address using uninitialized values allocated on
the stack, avoiding bigger changes since regression tests are not available to
properly verify functionality.

This closes #656


> [clang-analyzer] Uninitialized stack value used in mp4 plugin
> -------------------------------------------------------------
>
>                 Key: TS-4366
>                 URL: https://issues.apache.org/jira/browse/TS-4366
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gancho Tenev
>            Assignee: Gancho Tenev
>             Fix For: 7.0.0
>
>
> Logic error: Result of operation is garbage or undefined
> Source: plugins/experimental/mp4/mp4_meta.cc: 951     
> Function: Mp4Meta::mp4_read_co64_atom():
> Within the expansion of the macro 'mp4_get_32value': 
>   The left operand of '<<' is a garbage value



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to