[
https://issues.apache.org/jira/browse/TS-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313018#comment-15313018
]
ASF GitHub Bot commented on TS-4503:
------------------------------------
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/694
Ok, I see you point. I have no love lost for MachineFatal. This is my
first encounter with it. I'll try replacing it's use in
ProtocolProbeSessionAccept with Fatal and add a ink_release_assert there.
Actually it just looks like it is used in the various Accept classes. I'll
look at replacing all 5 instances and removing MachineFatal.
> MachineFatal should shutdown without cleanup
> --------------------------------------------
>
> Key: TS-4503
> URL: https://issues.apache.org/jira/browse/TS-4503
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> When MachineFatalClass::raise() is called, it prints a message to the log and
> then calls exit. exit causes memory cleanup to be called. But if we are in
> such bad state that MachineFatal is called, it is quite likely that memory is
> messed up.
> We saw a crash where MachineFatal is called in thread 84. This stack has the
> real error. But the stack that got reported was on thread 1 in class
> destructor logic. It would have been better if ATS failed immediately and
> the stack on thread 84 was reported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
