[
https://issues.apache.org/jira/browse/TS-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344640#comment-15344640
]
ASF GitHub Bot commented on TS-4507:
------------------------------------
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/717
@shinrich I'd really like to see some exhaustive code comments about how
transaction destruction is supposed to work and how to operate this machinery.
Just looking at the diff it really looks like black magic.
I'm concerned about the maintainability of ``destroy()``, ``do_destroy()``
and ``really_destroy()``; maybe if you can explain the context we can come up
with some cleaner way to express the intent?
Of course, the testing question :) Is there a way to test this either in
regression tests or in tsqa (or its successor)?
> It is still possible for SSN_CLOSE hook to be called before TXN_CLOSE hook
> --------------------------------------------------------------------------
>
> Key: TS-4507
> URL: https://issues.apache.org/jira/browse/TS-4507
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> One of our plugins will occasionally crash. It appears there is still a path
> for HTTP2 that has the SSN_CLOSE hook close before the TXN_CLOSE hook.
> Working through solutions that delay the SSN_CLOSE hook until after all the
> TXN_CLOSE hooks, but does not lose the SSN_CLOSE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
