[ 
https://issues.apache.org/jira/browse/TS-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350308#comment-15350308
 ] 

ASF GitHub Bot commented on TS-4518:
------------------------------------

Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/736#discussion_r68513514
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -8941,3 +8942,110 @@ TSVConnReenable(TSVConn vconn)
         }
       }
     }
    +
    +// APIs for managing and using UUIDs.
    +TSUuid
    +TSUuidCreate(void)
    +{
    +  ATSUuid *uuid = new ATSUuid();
    +  return (TSUuid)uuid;
    +}
    +
    +TSReturnCode
    +TSUuidDestroy(TSUuid uuid)
    +{
    +  sdk_assert(sdk_sanity_check_null_ptr((void *)uuid) == TS_SUCCESS);
    +  ATSUuid *u = (ATSUuid *)uuid;
    +
    +  if (u->alive()) {
    --- End diff --
    
    It used to do more, but not it just does a poor amount of sanity check, and 
it certainly can not be a guarantee. It could not be a false negative though. 
It'd probably make more sense if the data was on a freelist, maybe.


> UUID and HttpSM ID APIs and Machine support for a process UUID
> --------------------------------------------------------------
>
>                 Key: TS-4518
>                 URL: https://issues.apache.org/jira/browse/TS-4518
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core, TS API
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 7.0.0
>
>
> As was discussed on https://github.com/apache/trafficserver/pull/199, I've 
> started the work to generalize this, and breaking it up in various parts.
> This first Jira is about adding four things:
> 1) An internal process UUID, which goes into Machine. It's accessible from 
> the core.
> 2) An API to get this Machine UUID.
> 3) A set of generic UUID APIs, to do things like stringification, Copy() etc.
> 4) A very simple API that exposes the HttpSM's sequences number (sm_id).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to