[
https://issues.apache.org/jira/browse/TS-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352234#comment-15352234
]
William Bardwell commented on TS-4506:
--------------------------------------
Your patch matches the description in the initial bug ticket, but not in the
comment and commit comment, and the patch seems backwards...(the later comments
seem right...don't delete Last-Modified unless there is an ETag that serves the
same purpose.)
I would argue that deleting the Last-Modified seems weird unless you are sure
that the client did a If-None-Match...otherwise (theoretically, although seems
pretty unlikely) they might not have an ETag to compare with...
Also isn't it removing Expires because it is hard coding Cache-Control to
no-store?
> Last-Modified and Expires headers are removed on 304 responses when they
> shouldn't
> ----------------------------------------------------------------------------------
>
> Key: TS-4506
> URL: https://issues.apache.org/jira/browse/TS-4506
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Right now, when ATS generates a 304 response (Not Modified), we always remove
> the Last-Modified header. Reading the RFC, we should only remove the
> Last-Modified header if there is no ETag header. This is a simple fix, and we
> should just do it IMO.
> It also always removes the Expires headers, which is outright wrong.
> From https://tools.ietf.org/html/rfc7232#page-18:
> {code}
> The server generating a 304 response MUST generate any of the
> following header fields that would have been sent in a 200 (OK)
> response to the same request: Cache-Control, Content-Location, Date,
> ETag, Expires, and Vary.
> Since the goal of a 304 response is to minimize information transfer
> when the recipient already has one or more cached representations, a
> sender SHOULD NOT generate representation metadata other than the
> above listed fields unless said metadata exists for the purpose of
> guiding cache updates (e.g., Last-Modified might be useful if the
> response does not have an ETag field).
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
