[
https://issues.apache.org/jira/browse/TS-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354419#comment-15354419
]
ASF GitHub Bot commented on TS-4601:
------------------------------------
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/762
TS-4601: Connection error from origin_max_connection with origin_max_…
…connections_queue set to 0 should not retry
In addition to changing the connect attempts to not retry in the case of an
over limit origin connection that is closed, added a stat to track how many
origin connections are being closed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit 6f95f87407fc16686c6a4b4e5e0b89dd9b926a23
Author: Susan Hinrichs <[email protected]>
Date: 2016-06-29T02:30:10Z
TS-4601: Connection error from origin_max_connection with
origin_max_connections_queue set to 0 should not retry
----
> Connection error from origin_max_connection with origin_max_connections_queue
> set to 0 should not retry
> -------------------------------------------------------------------------------------------------------
>
> Key: TS-4601
> URL: https://issues.apache.org/jira/browse/TS-4601
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
>
> While adding a metric to track the number of times a connection to origin is
> dropped due to being over the origin_max_connections limit, I noticed that
> the count was increments three times as fast as I expected from my
> experiment. My connection retry count was 3. I changed the logic to set the
> current attempts to max to avoid the retries in that case.
> [~jacksontj] avoiding the retries makes sense in this case, right?
> I also propose adding a proxy.process.http.origin_connections_throttled
> metric to track how many connections to origin are being error'ed out the
> origin_max_connection limit. The metric is only incremented when the queue
> is 0 or we are over the delay queued limit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
