[
https://issues.apache.org/jira/browse/TS-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359230#comment-15359230
]
ASF GitHub Bot commented on TS-4629:
------------------------------------
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/780
TS-4629: Fix use of invalid iterator in ServerSessionPool::purge.
Add postfix increment to IPHashTable::iterator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/780.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #780
----
commit c23a02f38719619726579377feaf88a0ce2aff7d
Author: Alan M. Carroll <[email protected]>
Date: 2016-07-01T16:36:36Z
TS-4629: Fix use of invalid iterator in ServerSessionPoll::purge.
Add postfix increment to IPHashTable::iterator.
----
> ServerSessionPool::purge can use an invalid iterator
> ----------------------------------------------------
>
> Key: TS-4629
> URL: https://issues.apache.org/jira/browse/TS-4629
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Alan M. Carroll
>
> {{purge}} calls {{do_io_close}} on the session via an iterator and
> {{do_io_close}} can cause the session to be de-allocated. Because the
> container links are intrusive this causes the iterator to be come invalid
> even though it hasn't been removed from the container.
> Also, in fixing this, I noticed {{IPHashTable::iterator}} didn't have a
> postfix increment operator, which I added because it's perfect for this
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
