[
https://issues.apache.org/jira/browse/TS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363604#comment-15363604
]
ASF GitHub Bot commented on TS-4610:
------------------------------------
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/763#discussion_r69666098
--- Diff: proxy/http/HttpSM.cc ---
@@ -200,7 +200,8 @@ HttpVCTable::cleanup_entry(HttpVCTableEntry *e)
// Update stats
switch (e->vc_type) {
case HTTP_UA_VC:
- //
HTTP_DECREMENT_DYN_STAT(http_current_client_transactions_stat);
+ // Moved to HttpSM::destroy
+ // HTTP_DECREMENT_DYN_STAT(http_current_client_transactions_stat);
--- End diff --
I don't know if we need to keep these commented out, but maybe just a
comment saying "Metrics are updated in ::destroy".
> Fix HTTP and HTTP2 stats
> ------------------------
>
> Key: TS-4610
> URL: https://issues.apache.org/jira/browse/TS-4610
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP, HTTP/2, Metrics
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> There are a number of problems with HTTP and HTTP2 stats. Some were
> introduced with TS-3612. Other problems appear to predate those changes.
> proxy.process.http.current_client_transactions was not being adequately
> decremented. With this fix it now corresponds to the number of active HttpSMs.
> proxy.process.http2.current_client_sessions wasn't being set accurately.
> proxy.process.http2.total_client_streams wasn't being set at all.
> Originally had the Http2 logic adjusting
> proxy.process.http.current_client_connections and
> proxy.process.http.total_client_connections. But decided to pull that out and
> just have it adjust the http2 versions of those stats. So proxy.process.http
> connection stats just refer to HTTP/1.x protocols (and SPDY) and
> proxy.process.http2 connection stats refer to HTTP/2 protocols. This gives
> monitoring and analysis tools the option to look at connections per protocol.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
