[
https://issues.apache.org/jira/browse/TS-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364562#comment-15364562
]
ASF GitHub Bot commented on TS-4396:
------------------------------------
Github user mingzym commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/786#discussion_r69764301
--- Diff: proxy/http/HttpSM.cc ---
@@ -7618,6 +7616,8 @@ HttpSM::do_redirect()
return;
}
+ redirection_tries++;
+
--- End diff --
hmm, looks like better to do redirection_tries++ when setting
redirect_in_process = true, if you consider a really redirection. good catch.
> Off-by-one error in max redirects with redirection enabled
> ----------------------------------------------------------
>
> Key: TS-4396
> URL: https://issues.apache.org/jira/browse/TS-4396
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Network
> Reporter: Felix Buenemann
> Assignee: Zhao Yongming
> Fix For: 7.0.0
>
>
> There is a problem in the current stable version 6.1.1 where the setting
> proxy.config.http.number_of_redirections = 1 is incorrectly checked when
> following origin redirects by setting proxy.config.http.redirection_enabled =
> 1.
> If the requested URL is not already cached, ATS returns the redirect response
> to the client instead of storing the target into the cache and returning it
> to the client.
> The problem can be fixed by using proxy.config.http.number_of_redirections =
> 2, but we are only following one redirect, so this is wrong.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
