[jira] [Comment Edited] (TS-4626) LogFile::close_file should not delete m_log handle

[Michael Chai (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TS-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358487#comment-15358487
 ] 

Michael Chai edited comment on TS-4626 at 7/12/16 4:25 AM:
-----------------------------------------------------------

@@ -236,8 +236,6 @@ LogFile::close_file()
{code:java}
      } else if (m_log) {
        m_log->close_file();
        Debug("log-file", "LogFile %s is closed", m_log->get_name());
-      delete m_log;
-      m_log = NULL;
      } else {
        Warning("LogFile %s is open but was not closed", m_name);
      }
{code}



was (Author: chaiman_ats):
@@ -236,8 +236,6 @@ LogFile::close_file()
{code:java}
      } else if (m_log) {
        m_log->close_file();
        Debug("log-file", "LogFile %s is closed", m_log->get_name());
{color:red}
       delete m_log;
       m_log = NULL;
{color}
      } else {
        Warning("LogFile %s is open but was not closed", m_name);
      }
{code}


> LogFile::close_file should not delete m_log handle
> --------------------------------------------------
>
>                 Key: TS-4626
>                 URL: https://issues.apache.org/jira/browse/TS-4626
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Michael Chai
>             Fix For: 7.0.0
>
>
> When log file was deleted on the disk, LogFile::check_fd will close file 
> handle and reopen again.delete m_log at this point will cause 
> LogFile::open_file return "LOG_FILE_COULD_NOT_OPEN_FILE" .  otherwise, will 
> cause trafficserver crash at LogFile::preproc_and_try_delete



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)