[
https://issues.apache.org/jira/browse/TS-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Peach updated TS-4660:
----------------------------
Description:
Error messages in {{RemapConfig.cc}} are horribly constructed and with flipping
between partial buffers it is easy to end up with silly messages like this:
{noformat}
[Jul 13 23:43:55.966] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1396
(remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
/n/trafficserver/etc/trafficserver/remap.config line 1:
{noformat}
If you fix that, then you might get this:
{noformat}
[Jul 13 23:57:08.528] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1400
(remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
/n/trafficserver/etc/trafficserver/remap.config line 1: [ReverseProxy]
Malformed line 1 in file /n/trafficserver/etc/trafficserver/remap.config
{noformat}
We should apply the {{config_parse_error}} object consistently through remap
parsing to make it easy to aggregate error messages that are actually useful.
Add {{SourceLocation}} support to {{config_parse_error}} to carry the location
of the parse error.
> Apply config_parse_error to remap loading errors
> ------------------------------------------------
>
> Key: TS-4660
> URL: https://issues.apache.org/jira/browse/TS-4660
> Project: Traffic Server
> Issue Type: Bug
> Components: Remap API
> Reporter: James Peach
>
> Error messages in {{RemapConfig.cc}} are horribly constructed and with
> flipping between partial buffers it is easy to end up with silly messages
> like this:
> {noformat}
> [Jul 13 23:43:55.966] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1396
> (remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
> /n/trafficserver/etc/trafficserver/remap.config line 1:
> {noformat}
> If you fix that, then you might get this:
> {noformat}
> [Jul 13 23:57:08.528] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1400
> (remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
> /n/trafficserver/etc/trafficserver/remap.config line 1: [ReverseProxy]
> Malformed line 1 in file /n/trafficserver/etc/trafficserver/remap.config
> {noformat}
> We should apply the {{config_parse_error}} object consistently through remap
> parsing to make it easy to aggregate error messages that are actually useful.
> Add {{SourceLocation}} support to {{config_parse_error}} to carry the
> location of the parse error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
