[
https://issues.apache.org/jira/browse/TS-4660?focusedWorklogId=25468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25468
]
ASF GitHub Bot logged work on TS-4660:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/16 07:54
Start Date: 14/Jul/16 07:54
Worklog Time Spent: 10m
Work Description: GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/796
TS-4660: Improve remap.config error messages.
Improve some of the confusion about which error message buffer to
use in remap_parse_config_bti. The final message is now constructed
to append the original failure message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4660
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #796
----
commit 7116377c90f170502709398d479ea2d941c62c77
Author: James Peach <[email protected]>
Date: 2016-07-14T07:50:59Z
TS-4660: Improve remap.config error messages.
Improve some of the confusion about which error message buffer to
use in remap_parse_config_bti. The final message is now constructed
to append the original failure message.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 25468)
Time Spent: 10m
Remaining Estimate: 0h
> Apply config_parse_error to remap loading errors
> ------------------------------------------------
>
> Key: TS-4660
> URL: https://issues.apache.org/jira/browse/TS-4660
> Project: Traffic Server
> Issue Type: Bug
> Components: Remap API
> Reporter: James Peach
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Error messages in {{RemapConfig.cc}} are horribly constructed and with
> flipping between partial buffers it is easy to end up with silly messages
> like this:
> {noformat}
> [Jul 13 23:43:55.966] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1396
> (remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
> /n/trafficserver/etc/trafficserver/remap.config line 1:
> {noformat}
> If you fix that, then you might get this:
> {noformat}
> [Jul 13 23:57:08.528] Server {0x7ffff7fde840} ERROR: <RemapConfig.cc:1400
> (remap_parse_config_bti)> [ReverseProxy] failed to add remap rule at
> /n/trafficserver/etc/trafficserver/remap.config line 1: [ReverseProxy]
> Malformed line 1 in file /n/trafficserver/etc/trafficserver/remap.config
> {noformat}
> We should apply the {{config_parse_error}} object consistently through remap
> parsing to make it easy to aggregate error messages that are actually useful.
> Add {{SourceLocation}} support to {{config_parse_error}} to carry the
> location of the parse error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
