[
https://issues.apache.org/jira/browse/TS-4304?focusedWorklogId=25564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25564
]
ASF GitHub Bot logged work on TS-4304:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/16 15:23
Start Date: 17/Jul/16 15:23
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/806
This is a good start, but it's missing a few things (I think at least, been
a while since I looked at this). Look at how the eval() function is handling
the different cases. But at least I think you need to
1) Support the remap vs transaction hook cases
2) Support the various qualifiers for each of those cases.
Now, while briefly looking at the eval() function, I see that it does not
handle all qualifiers properly. I'm not sure what exactly happen here, but it's
likely related to https://issues.apache.org/jira/browse/TS-4146 . Somewhere
something went wrong, and instead of implementing the proper qualifiers, we
added new operators for e.g. PATH etc. :-/.
I'm if you only make ::append_value() support the same features and
qualifiers as the eval() method does today. And if so, just make a comment on
TS-4146, reminding us that we also have to support more qualifiers (path etc.)
in the append_value() method as well.
Cheers!
Issue Time Tracking
-------------------
Worklog Id: (was: 25564)
Time Spent: 20m (was: 10m)
> header_rewrite: There is no implementation of ConditionUrl::append_value for
> URL's
> ----------------------------------------------------------------------------------
>
> Key: TS-4304
> URL: https://issues.apache.org/jira/browse/TS-4304
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Labels: newbie
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The lack of implementation of ConditionUrl::append_value() means that we can
> not use these are part of e.g. a set-header operand. I'm not sure why this is
> not implemented, seems like it ought to be fairly straight forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
