Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/806
  
    This is a good start, but it's missing a few things (I think at least, been 
a while since I looked at this). Look at how the eval() function is handling 
the different cases. But at least I think you need to
    
    1) Support the remap vs transaction hook cases
    
    2) Support the various qualifiers for each of those cases.
    
    
    Now, while briefly looking at the eval() function, I see that it does not 
handle all qualifiers properly. I'm not sure what exactly happen here, but it's 
likely related to https://issues.apache.org/jira/browse/TS-4146 . Somewhere 
something went wrong, and instead of implementing the proper qualifiers, we 
added new operators for e.g. PATH etc. :-/.
    
    I'm if you only make ::append_value() support the same features and 
qualifiers as the eval() method does today. And if so, just make a comment on 
TS-4146, reminding us that we also have to support more qualifiers (path etc.) 
in the append_value() method as well.
    
    Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to