[
https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25567
]
ASF GitHub Bot logged work on TS-4624:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/16 15:29
Start Date: 17/Jul/16 15:29
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/804#discussion_r71084262
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -750,12 +752,10 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd
via_string += nstrcpy(via_string, s->http_config_param->proxy_hostname);
*via_string++ = '[';
- /* I thought we should use the transaction local outgoing IP address but
- that makes cycle detection (which is the point) unrealiable. We must
- use the same value every time to be sure.
- */
- memcpy(via_string, Machine::instance()->ip_hex_string,
Machine::instance()->ip_hex_string_len);
- via_string += Machine::instance()->ip_hex_string_len;
+ if (uuid != NULL) {
--- End diff --
I don't think the machine uuid can ever be NULL, but harmless to check I
guess :).
Issue Time Tracking
-------------------
Worklog Id: (was: 25567)
Time Spent: 50m (was: 40m)
> use the server UUID in the Via header
> -------------------------------------
>
> Key: TS-4624
> URL: https://issues.apache.org/jira/browse/TS-4624
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: James Peach
> Assignee: Pavlo Yatsukhnenko
> Labels: newbie
> Fix For: 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [~zwoop] should we use the server UUID in the Via header?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
