Github user yatsukhnenko commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/804#discussion_r71084817
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -750,12 +752,10 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd
via_string += nstrcpy(via_string, s->http_config_param->proxy_hostname);
*via_string++ = '[';
- /* I thought we should use the transaction local outgoing IP address but
- that makes cycle detection (which is the point) unrealiable. We must
- use the same value every time to be sure.
- */
- memcpy(via_string, Machine::instance()->ip_hex_string,
Machine::instance()->ip_hex_string_len);
- via_string += Machine::instance()->ip_hex_string_len;
+ if (uuid != NULL) {
--- End diff --
Reinsurance :) Shoul I delete this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
