Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/810#discussion_r71376108
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2010,8 +2013,9 @@ ssl_extract_certificate(const matcher_line
*line_info, ssl_user_config &sslMultC
}
}
if (!sslMultCertSettings.cert) {
- Warning("missing %s tag", SSL_CERT_TAG);
- return false;
+ // TS-4679: It is ok to be missing the cert. At least if the action
is set to tunnel
--- End diff --
I think you should just nuke this commented code, and maybe add a comment
above about the special lenience case for the tunneling (where you check if
sslMultCertSettings.cert is NULL or not).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
