[
https://issues.apache.org/jira/browse/TS-4671?focusedWorklogId=25694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25694
]
ASF GitHub Bot logged work on TS-4671:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/16 16:40
Start Date: 19/Jul/16 16:40
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/810#discussion_r71376108
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2010,8 +2013,9 @@ ssl_extract_certificate(const matcher_line
*line_info, ssl_user_config &sslMultC
}
}
if (!sslMultCertSettings.cert) {
- Warning("missing %s tag", SSL_CERT_TAG);
- return false;
+ // TS-4679: It is ok to be missing the cert. At least if the action
is set to tunnel
--- End diff --
I think you should just nuke this commented code, and maybe add a comment
above about the special lenience case for the tunneling (where you check if
sslMultCertSettings.cert is NULL or not).
Issue Time Tracking
-------------------
Worklog Id: (was: 25694)
Time Spent: 40m (was: 0.5h)
> Revisit Machine::ip
> -------------------
>
> Key: TS-4671
> URL: https://issues.apache.org/jira/browse/TS-4671
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
> Reporter: James Peach
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{Machine::ip}} is used in ICP, logging and loop detection. The latter two
> use cases can be largely handled by the machine UUID now. Since
> {{Machine::ip}} doesn't play nicely with multi-homed servers, consider
> whether we should remove it and deal with the remaining use cases differently?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
