Github user gtenev commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/818#discussion_r71735386
  
    --- Diff: plugins/header_rewrite/ruleset.cc ---
    @@ -51,7 +51,7 @@ RuleSet::add_condition(Parser &p, const char *filename)
         if (!c->set_hook(_hook)) {
           TSError("[%s] in %s: can't use this condition in hook=%d: %%{%s} 
with arg: %s", PLUGIN_NAME, filename, _hook,
    --- End diff --
    
    @zwoop, do you think it would make sense to print the hook name instead of 
the number? 
    Having the number is a great help for the developers but the operators 
would not know what it means.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to