[
https://issues.apache.org/jira/browse/TS-4683?focusedWorklogId=25809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25809
]
ASF GitHub Bot logged work on TS-4683:
--------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/16 16:06
Start Date: 21/Jul/16 16:06
Worklog Time Spent: 10m
Work Description: Github user gtenev commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/818#discussion_r71735386
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -51,7 +51,7 @@ RuleSet::add_condition(Parser &p, const char *filename)
if (!c->set_hook(_hook)) {
TSError("[%s] in %s: can't use this condition in hook=%d: %%{%s}
with arg: %s", PLUGIN_NAME, filename, _hook,
--- End diff --
@zwoop, do you think it would make sense to print the hook name instead of
the number?
Having the number is a great help for the developers but the operators
would not know what it means.
Issue Time Tracking
-------------------
Worklog Id: (was: 25809)
Time Spent: 1.5h (was: 1h 20m)
> header_rewrite: warning if you use a hook that predates "remap" in a remap
> mode
> -------------------------------------------------------------------------------
>
> Key: TS-4683
> URL: https://issues.apache.org/jira/browse/TS-4683
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> It's rather confusing, but since remap happens after several of the hooks
> that header_rewrite supports (in global mode), we should warn the user that
> this is a no-op (or maybe even error out).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
