[ https://issues.apache.org/jira/browse/TS-4612?focusedWorklogId=25823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25823 ]
ASF GitHub Bot logged work on TS-4612: -------------------------------------- Author: ASF GitHub Bot Created on: 21/Jul/16 18:29 Start Date: 21/Jul/16 18:29 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/771 @bryancall Should we merge this? [approve ci]. Issue Time Tracking ------------------- Worklog Id: (was: 25823) Time Spent: 1h 10m (was: 1h) > Proposal: InactivityCop Optimize > -------------------------------- > > Key: TS-4612 > URL: https://issues.apache.org/jira/browse/TS-4612 > Project: Traffic Server > Issue Type: Bug > Components: Core, Network > Reporter: Oknet Xu > Fix For: sometime > > Time Spent: 1h 10m > Remaining Estimate: 0h > > By review the processing of InactivityCop::check_inactivity(): > 1. get all local vc from open_list > 2. put them into cop_list > 3. check every vc in cop_list if it is already timeouted > 4. callback vc->handleEvent to close vc if it is timeout > InactivityCop and NetHandler share one mutex. > InactivityCop runs every second, NetHandler runs every 10ms, that means > Nethandler runs 100 times until next InactivityCop runs. > if one vc has read/write in a Nethandler call, it is won't be timeout in the > next InactivityCop run. > Thus, if the vc has read/write in Nethandler, we move it out of cop-list then > the InactivityCop runs would get better performace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)