[
https://issues.apache.org/jira/browse/TS-4554?focusedWorklogId=26116&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26116
]
ASF GitHub Bot logged work on TS-4554:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/16 09:51
Start Date: 01/Aug/16 09:51
Worklog Time Spent: 10m
Work Description: Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/830
1) 256 seems crazy deep, is that a reasonable default?
SETTINGS_MAX_CONCURRENT_STREAMS is 100 at least. And "idle" streams (that
are not counted for concurrent streams) can be node of tree.
Those can be said for odd-numbered streams which is used by client and
even-numbered streams which is used by server. So I chose 256.
If we ignore server-push cases, it could be 128.
2) Do we want to make this configurable instead of static? Are there use
cases where someone want more (or less) ?
Hmm, if someone wants to increase SETTINGS_MAX_CONCURRENT_STREAMS, it looks
like this should be increased too. But this is a limit of recursion, so I don't
think this should be configurable for now.
Issue Time Tracking
-------------------
Worklog Id: (was: 26116)
Time Spent: 1h (was: 50m)
> ASAN crash (stack overflow) with H2 priorities
> ----------------------------------------------
>
> Key: TS-4554
> URL: https://issues.apache.org/jira/browse/TS-4554
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Affects Versions: 7.0.0
> Reporter: Leif Hedstrom
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I'm seeing (truncated):
> {code}
> ASAN:SIGSEGV
> =================================================================
> ==11178==ERROR: AddressSanitizer: stack-overflow on address 0x2aab63633ff0
> (pc 0x0000007ddaa9 bp 0x2aab63634050 sp 0x2aab63633ff0 T6)
> #0 0x7ddaa8 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:134
> #1 0x7ddaa8 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:140
> #2 0x7ddaa8 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:140
> .
> .
> .
> #2261 0x7ddc34 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:140
> #2262 0x7ddc34 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:140
> #2263 0x7ddc34 in
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:140
> SUMMARY: AddressSanitizer: stack-overflow
> /usr/local/src/trafficserver/proxy/http2/Http2DependencyTree.h:134
> Http2DependencyTree<Http2Stream*>::_find(Http2DependencyTree<Http2Stream*>::Node*,
> unsigned int)
> Thread T6 ([ET_NET 5]) created by T0 ([ET_NET 0]) here:
> #0 0x2aab5b0d50c4 in __interceptor_pthread_create
> ../../../../libsanitizer/asan/asan_interceptors.cc:179
> #1 0xcfdb99 in ink_thread_create ../../lib/ts/ink_thread.h:147
> #2 0xcfdb99 in Thread::start(char const*, unsigned long, void*
> (*)(void*), void*)
> /usr/local/src/trafficserver/iocore/eventsystem/Thread.cc:99
> #3 0xd0562e in EventProcessor::start(int, unsigned long)
> /usr/local/src/trafficserver/iocore/eventsystem/UnixEventProcessor.cc:140
> #4 0x497b59 in main /usr/local/src/trafficserver/proxy/Main.cc:1746
> #5 0x2aab5ee11b14 in __libc_start_main (/lib64/libc.so.6+0x21b14)
> ==11178==ABORTING
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
