Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/847#discussion_r74273262
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader
*buf_reader, int64_t write_len,
parent->connection_state.send_headers_frame(this);
// See if the response is chunked. Set up the dechunking logic if
it is
- is_done = this->response_initialize_data_handling();
+ this->response_initialize_data_handling();
--- End diff --
Should you check or assert on the return value here? I would guess that bad
things happen if ``response_initialize_data_handling`` returns false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
