Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/848#discussion_r74351692
  
    --- Diff: plugins/regex_remap/README ---
    @@ -53,11 +54,19 @@ to turn this off use the option 'no-query-string', e.g.
        ... @pparam=maps.reg @pparam=no-query-string
     
     
    -Finally, you can also include the matrix parameters in the string, using 
the
    +You can also include the matrix parameters in the string, using the
     option 'matrix-parameters', e.g.
     
        ... @pparam=maps.reg @pparam=matrix-parameters
     
    +Finally, to match on the host as well, use the option 'host', e.g. ::
    +
    +   ... @pparam=maps.reg @pparam=host
    +
    +With this enabled, the string that you will need to match will look like
    +
    +    //host/path?query=bar
    +
     
     Note that the path to the plugin must be absolute, and by default it is
     
    --- End diff --
    
    I wonder if it's time to remove this README, now that we have good 
documentation on docs.trafficserver. Not necessarily for this PR, but maybe 
file a separate Jira/PR to just nuke this README? Duplicated docs just makes 
life miserable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to