[
https://issues.apache.org/jira/browse/TS-110?focusedWorklogId=26316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26316
]
ASF GitHub Bot logged work on TS-110:
-------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/16 23:46
Start Date: 10/Aug/16 23:46
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/848#discussion_r74351870
--- Diff: plugins/regex_remap/regex_remap.cc ---
@@ -759,15 +761,19 @@ TSRemapNewInstance(int argc, char *argv[], void **ih,
char * /* errbuf ATS_UNUSE
} else if (strncmp(argv[i], "method", 6) == 0) {
ri->method = true;
} else if (strncmp(argv[i], "no-method", 9) == 0) {
- ri->method = true;
+ ri->method = false;
} else if (strncmp(argv[i], "query-string", 12) == 0) {
ri->query_string = true;
} else if (strncmp(argv[i], "no-query-string", 15) == 0) {
ri->query_string = false;
- } else if (strncmp(argv[i], "matrix-parameters", 15) == 0) {
+ } else if (strncmp(argv[i], "matrix-parameters", 17) == 0) {
ri->matrix_params = true;
- } else if (strncmp(argv[i], "no-matrix-parameters", 18) == 0) {
+ } else if (strncmp(argv[i], "no-matrix-parameters", 20) == 0) {
ri->matrix_params = false;
--- End diff --
Wth, who wrote this crap. Can you put a comment on the Jira / description
and also indicate that we fixed these completely broken cases as well here?
Issue Time Tracking
-------------------
Worklog Id: (was: 26316)
Time Spent: 40m (was: 0.5h)
> Improve regex remap to allow substitutions in path field
> --------------------------------------------------------
>
> Key: TS-110
> URL: https://issues.apache.org/jira/browse/TS-110
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Priority: Minor
> Fix For: sometime
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, regex support covers only the host field of the remap rules. It'd
> be nice to extend this to allow substitutions into the path field as well.
> This will allow rules like:
> regex_map http://www.example-(.*).com/ http://real-example.com/$1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
