[ https://issues.apache.org/jira/browse/TS-4548?focusedWorklogId=26340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26340 ]
ASF GitHub Bot logged work on TS-4548: -------------------------------------- Author: ASF GitHub Bot Created on: 11/Aug/16 22:14 Start Date: 11/Aug/16 22:14 Worklog Time Spent: 10m Work Description: Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/851#discussion_r74513800 --- Diff: proxy/logging/LogConfig.cc --- @@ -493,14 +494,21 @@ void LogConfig::setup_log_objects() { Debug("log", "creating objects..."); + RecBool enable_lua = false; + + RecGetRecordBool("proxy.config.log.config.enable_lua", &enable_lua); --- End diff -- I think you should nuke this config, and just make the new config default. Issue Time Tracking ------------------- Worklog Id: (was: 26340) Time Spent: 1h 20m (was: 1h 10m) > Convert custom log config file to Lua > ------------------------------------- > > Key: TS-4548 > URL: https://issues.apache.org/jira/browse/TS-4548 > Project: Traffic Server > Issue Type: Improvement > Components: Logging, Lua > Reporter: James Peach > Assignee: James Peach > Fix For: 7.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Custom logs {{logs_xml.config}} is a good candidate to convert to Lua > bindings. I'm thinking that we bind fairly directly to the internal logging > objects so that conceptually it is the same but instead of using XML to > construct objects, you use Lua. We would just construct Lua states on the fly > to evaluate the file. > This is the last usage of XML and would let us nuke {{proxy/shared/InkXml.*}} > as well as our dependencies on expat+libxml2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)