Github user maskit commented on the issue:

    https://github.com/apache/trafficserver/pull/866
  
    I don't think this is the right approach. With this change, "%%20" will be 
encoded to "%25%20", right? What if "%%20" was not encoded string? It should be 
encoded to "%25%2520".
    Shouldn't we make sure that all callers of this function pass decoded URLs?
    
    Another options is to abort encoding and return inputs as outputs if input 
URLs seem to be already encoded. It can't handle mixed cases but I think it 
would't happen. (If it happens, it should be a bug.)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to