[
https://issues.apache.org/jira/browse/TS-4743?focusedWorklogId=26565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26565
]
ASF GitHub Bot logged work on TS-4743:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/16 08:10
Start Date: 18/Aug/16 08:10
Worklog Time Spent: 10m
Work Description: GitHub user keith2008 opened a pull request:
https://github.com/apache/trafficserver/pull/873
fix 5 bugs about parent strategy
Fix the following bugs:
(TS-4743) parent use consistent_hash Strategy may cause crash while first
parent is not set
(TS-4744) ParentConsistentHash::selectParent may select the unavailable
parent
(TS-4745) pRecord.failCount not init inParentRecord::ProcessParents
(TS-4746) ParentRecord *secondary_parents malloc, but no place free,which
will cause memery leak
(TS-4747) if the connection of parent is notalive, not make the parent host
down,which will select the the unavailablehost again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith2008/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 977dff9849462ee6dfcbe51de89d38f47837fff8
Author: keith2008 <[email protected]>
Date: 2016-08-18T06:37:06Z
Update ParentSelection.cc
commit 7ac6299ecb9b8365a5de5d6620a302c3df07909a
Author: keith2008 <[email protected]>
Date: 2016-08-18T06:42:05Z
Update HttpTransact.cc
(TS-4747) if the connection of parent is notalive, not make the parent host
down,which will select the the unavailablehost again
commit 473ed61b89c764be909a91c79dc0c84333bc75aa
Author: keith2008 <[email protected]>
Date: 2016-08-18T06:46:02Z
Update ParentConsistentHash.cc
(TS-4744) ParentConsistentHash::selectParent mayselect the unavailable
parent
commit cb1c56debd53287a54f52410193cd35bcf0f7c53
Author: keith2008 <[email protected]>
Date: 2016-08-18T06:56:21Z
Update ParentSelection.cc
(TS-4746) ParentRecord *secondary_parentsmalloc,but no place free,which
will cause memery leak
commit 8fcfc0a060e42995318e9c0c7abac7981446eb46
Author: keith2008 <[email protected]>
Date: 2016-08-18T07:31:44Z
Update ParentConsistentHash.cc
commit ef555fe77fc13bd613e83809b43b7cb5a5caa8fe
Author: keith2008 <[email protected]>
Date: 2016-08-18T07:35:59Z
Update ParentSelection.cc
commit d8eee07022d50588d92f3faf252493b478810bb8
Author: keith2008 <[email protected]>
Date: 2016-08-18T07:49:45Z
Update ParentConsistentHash.cc
(TS-4743) parent use consistent_hash Strategy may cause crash while first
parent is not set
----
Issue Time Tracking
-------------------
Worklog Id: (was: 26565)
Time Spent: 10m
Remaining Estimate: 0h
> parent use consistent_hash Strategy may cause crash while first parent is not
> set
> ----------------------------------------------------------------------------------
>
> Key: TS-4743
> URL: https://issues.apache.org/jira/browse/TS-4743
> Project: Traffic Server
> Issue Type: Bug
> Reporter: xiangdong chen
> Assignee: John Rushford
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> my parent.config
> eg :
> dest_domain=. secondary_parent="192.168.104.229:80|1.0;
> 192.168.104.182:80|1.0" round_robin=consistent_hash
> the crash place is :
> DEBUG: <ParentConsistentHash.cc:167 (selectParent)> (parent_select)
> wrap_around[PRIMARY]: 1, wrap_around[SECONDARY]: 0
> traffic_server: Segmentation fault (Address not mapped to object [0x10])
> ParentConsistentHash.cc:167 code:
> Debug("parent_select", "Selected parent %s is not available, looking up
> another parent.", pRec->hostname);
> Fix the code like
> Debug("parent_select", "Selected parent %s is not available, looking up
> another parent.", pRec ? pRec->hostname:"[NULL]");
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
