[
https://issues.apache.org/jira/browse/TS-4696?focusedWorklogId=26573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26573
]
ASF GitHub Bot logged work on TS-4696:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/16 15:35
Start Date: 18/Aug/16 15:35
Worklog Time Spent: 10m
Work Description: GitHub user strotyl opened a pull request:
https://github.com/apache/trafficserver/pull/874
TS-4696: Coverity 1267824: Missing unlock in mgmt/Alarms.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/strotyl/trafficserver TS-4696
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/874.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #874
----
commit 67fc2b34afdab551d09d12f476ad0ded17f76d33
Author: Tyler Stroh <[email protected]>
Date: 2016-07-22T16:44:19Z
TS-4696: Coverity 1267824: Missing unlock in mgmt/Alarms.cc
----
Issue Time Tracking
-------------------
Worklog Id: (was: 26573)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1267824: Missing unlock in mgmt/Alarms.cc
> ---------------------------------------------
>
> Key: TS-4696
> URL: https://issues.apache.org/jira/browse/TS-4696
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Tyler Stroh
> Assignee: Tyler Stroh
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> 2. lock: ink_mutex_acquire locks this->mutex. [show details]
> ink_mutex_acquire(&mutex);
> if (!((n + (int)strlen("type: alarm\n")) < max)) {
> if (max >= 1) {
> message[0] = '\0';
> }
> CID 1267824 (#1 of 1): Missing unlock (LOCK)
> 5. missing_unlock: Returning without unlocking this->mutex.
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
