Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/880#discussion_r75420890
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
const char *uuid = (char *)Machine::instance()->uuid.getString();
int len;
- len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid,
m_http_sm->sm_id);
- marshal_str(buf, str, round_strlen(len + 1));
+ len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid,
m_http_sm->sm_id);
--- End diff --
> On Aug 18, 2016, at 7:25 PM, Leif Hedstrom <[email protected]>
wrote:
>
> In proxy/logging/LogAccessHttp.cc:
>
> > @@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf)
> > const char *uuid = (char *)Machine::instance()->uuid.getString();
> > int len;
> >
> > - len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid,
m_http_sm->sm_id);
> > - marshal_str(buf, str, round_strlen(len + 1));
> > + len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid,
m_http_sm->sm_id);
> Isn't this fixed/addressed in a separate PR?
>
Yeh I just branched this from the other PR
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
