[ https://issues.apache.org/jira/browse/TS-4601?focusedWorklogId=26684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26684 ]
ASF GitHub Bot logged work on TS-4601: -------------------------------------- Author: ASF GitHub Bot Created on: 19/Aug/16 23:28 Start Date: 19/Aug/16 23:28 Worklog Time Spent: 10m Work Description: Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/762#discussion_r75564926 --- Diff: proxy/http/HttpConfig.cc --- @@ -809,6 +809,8 @@ register_stat_callbacks() (int)https_incoming_requests_stat, RecRawStatSyncCount); RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.https.total_client_connections", RECD_COUNTER, RECP_PERSISTENT, (int)https_total_client_connections_stat, RecRawStatSyncCount); + RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.http.origin_connections_throttled", RECD_COUNTER, RECP_PERSISTENT, --- End diff -- Actually the throttling limit affects both incoming and outgoing connections. I could create origin_connections_throttled_in and origin_connections_throttled out. Issue Time Tracking ------------------- Worklog Id: (was: 26684) Time Spent: 20m (was: 10m) > Connection error from origin_max_connection with origin_max_connections_queue > set to 0 should not retry > ------------------------------------------------------------------------------------------------------- > > Key: TS-4601 > URL: https://issues.apache.org/jira/browse/TS-4601 > Project: Traffic Server > Issue Type: Bug > Components: Core > Reporter: Susan Hinrichs > Assignee: Susan Hinrichs > Fix For: 7.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > While adding a metric to track the number of times a connection to origin is > dropped due to being over the origin_max_connections limit, I noticed that > the count was increments three times as fast as I expected from my > experiment. My connection retry count was 3. I changed the logic to set the > current attempts to max to avoid the retries in that case. > [~jacksontj] avoiding the retries makes sense in this case, right? > I also propose adding a proxy.process.http.origin_connections_throttled > metric to track how many connections to origin are being error'ed out the > origin_max_connection limit. The metric is only incremented when the queue > is 0 or we are over the delay queued limit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)