Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/871#discussion_r75571646
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8059,12 +8059,8 @@ HttpTransact::build_response(State *s, HTTPHdr
*base_response, HTTPHdr *outgoing
// If the response is prohibited from containing a body,
// we know the content length is trustable for keep-alive
- if (is_response_body_precluded(status_code, s->method)) {
- s->hdr_info.trust_response_cl = true;
- s->hdr_info.response_content_length = 0;
- s->client_info.transfer_encoding =
HttpTransact::NO_TRANSFER_ENCODING;
- s->server_info.transfer_encoding =
HttpTransact::NO_TRANSFER_ENCODING;
- }
+ if (is_response_body_precluded(status_code, s->method))
--- End diff --
Nit pick, but we shouldn't eliminate {} in conditionals, it's just a bad
habit. Always use the format
if ( ...) {
// Stuff
}
even for single line conditionals.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
