[
https://issues.apache.org/jira/browse/TS-4746?focusedWorklogId=26856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26856
]
ASF GitHub Bot logged work on TS-4746:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/16 01:13
Start Date: 23/Aug/16 01:13
Worklog Time Spent: 10m
Work Description: GitHub user keith2008 opened a pull request:
https://github.com/apache/trafficserver/pull/902
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which
will cause memery leak
ParentRecord *secondary_parents malloc, but no place free,which will cause
memery leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith2008/trafficserver TS-4746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #902
----
commit 8a76d21f5194cb31e514860319b8fcae2d2648be
Author: keith2008 <[email protected]>
Date: 2016-08-23T00:42:30Z
TS-4743: parent use consistent_hash Strategy may cause crash while first
parent is not set
commit 3deb52397b047455ba8aba3e5132e3daafa980ad
Author: keith2008 <[email protected]>
Date: 2016-08-23T00:51:44Z
TS-4744: ParentConsistentHash::selectParent may select the unavailable
parent
commit 49beaa5b5fd712c1d8383b081fc8479ec680ae0a
Author: keith2008 <[email protected]>
Date: 2016-08-23T00:58:54Z
TS-4745: pRecord.failCount not init in ParentRecord::ProcessParents
commit 1159f47044e7add14ccaa84bf110895e244599b0
Author: keith2008 <[email protected]>
Date: 2016-08-23T01:12:22Z
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which
will cause memery leak
----
Issue Time Tracking
-------------------
Worklog Id: (was: 26856)
Time Spent: 20m (was: 10m)
> ParentRecord *secondary_parents malloc,but no place free,which will cause
> memery leak
> -------------------------------------------------------------------------------------
>
> Key: TS-4746
> URL: https://issues.apache.org/jira/browse/TS-4746
> Project: Traffic Server
> Issue Type: Bug
> Components: Parent Proxy
> Reporter: xiangdong chen
> Assignee: John Rushford
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> secondary_parents is malloc in
> ParentRecord::ProcessParents(char *val, bool isPrimary)
> this->secondary_parents = (pRecord *)ats_malloc(sizeof(pRecord) * numTok);
> //line:372
> but no place to free it,which will cause memery leak.
> fix in
> ParentRecord::~ParentRecord()
> {
> if(parents != NULL) {
> ats_free(parents);
> }
> if(primary_parents != NULL){
> ats_free(primary_parents);
> }
> if(second_parents != NULL){
> ats_free(second_parents);
> }
> ......
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
