Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/843#discussion_r75879815
--- Diff: plugins/experimental/carp/UrlComponents.h ---
@@ -0,0 +1,219 @@
+/** @file
+
+ URL helper
+
+ @section license License
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+#ifndef __URLCOMPONENTS_H__
+#define __URLCOMPONENTS_H__ 1
+
+#include <cstdio>
+///////////////////////////////////////////////////////////////////////////////
+// Class holding one request URL's component.
+//
+
+struct UrlComponents
+{
+
+ UrlComponents()
+ : _port(0)
+ {
+ }
+
+ void populate(TSMBuffer bufp, TSMLoc urlLoc)
+ {
+ int scheme_len;
+ int host_len;
+ int path_len;
+ int query_len;
+ int matrix_len;
+
+ const char* scheme = TSUrlSchemeGet(bufp, urlLoc, &scheme_len);
+ const char* host = TSUrlHostGet(bufp, urlLoc, &host_len);
+ const char* path = TSUrlPathGet(bufp, urlLoc, &path_len);
+ const char* query = TSUrlHttpQueryGet(bufp, urlLoc, &query_len);
+ const char* matrix = TSUrlHttpParamsGet(bufp, urlLoc, &matrix_len);
+ _port = TSUrlPortGet(bufp, urlLoc);
+
+ _scheme.assign(scheme, scheme_len);
+ _host.assign(host, host_len);
+ _path.assign(path, path_len);
+ _query.assign(query, query_len);
+ _matrix.assign(matrix, matrix_len);
+
+ }
+
+ // get entire url (e.g.http://host/path?query)
+ void construct(std::string & url)
+ {
+ // schemeExtra= :// = 3
+ // portExtra = :xxxxx = 6
+ // just in case extra = 32
+ size_t iLen = _scheme.size() + _host.size() + _path.size() +
_query.size() + _matrix.size() + 3 + 6 + 32;
+ url.reserve(iLen);
+
+ size_t pos = _host.find(":");
+ if (pos != std::string::npos) {
+ // Strip the embeded port
+ // If the port is non-standard it will be added back below
+ _host.resize(pos);
+ }
+
+ const int bitAddPort = 1;
+ const int bitAddQuery = 1 << 1;
+ const int bitAddMatrix = 1 << 2;
+ int bitField = bitAddPort; // add port by default
+ if ((_scheme.compare("http") == 0 && _port == 80) ||
(_scheme.compare("https") == 0 && _port == 443) ) bitField &= ~bitAddPort;
+ if (_query.size() != 0) bitField |= bitAddQuery;
+ if (_matrix.size() != 0) bitField |= bitAddMatrix;
+
+ switch (bitField) {
+ case 0: // default port, no query, no matrix
+ url = _scheme + "://" + _host + "/" + _path;
+ break;
+
+ case bitAddPort:
+ { // port, no query, no matrix
+ char sTemp[10];
+ url = _scheme + "://" + _host + ":";
+ sprintf(sTemp, "%d", _port);
+ url += sTemp;
+ url += "/" + _path;
+ break;
+ }
+
+ case bitAddQuery: // default port, with query, no matrix
+ url = _scheme + "://" + _host + "/" + _path + "?" + _query;
+ break;
+ case bitAddQuery | bitAddMatrix: // default port, with query, with
matrix (even possible?)
+ url = _scheme + "://" + _host + "/" + _path + ";" + _matrix + "?" +
_query;
+ break;
+
+ case bitAddMatrix: // default port, no query, with matrix
+ url = _scheme + "://" + _host + "/" + _path + ";" + _matrix;
+ break;
+
+ case bitAddPort | bitAddQuery: // port, with query, no matrix
+ { //port, with query, with matrix (even possible?)
+ char sTemp[10];
+ url = _scheme + "://" + _host + ":";
+ sprintf(sTemp, "%d", _port);
+ url += sTemp;
+ url += "/" + _path + "?" + _query;
+ break;
+ }
+
+ case bitAddPort | bitAddQuery | bitAddMatrix:
+ { //port, with query, with matrix (even possible?)
+ char sTemp[10];
+ url = _scheme + "://" + _host + ":";
+ sprintf(sTemp, "%d", _port);
+ url += sTemp;
+ url += "/" + _path + ";" + _matrix + "?" + _query;
+ break;
+ }
+
+ case bitAddPort | bitAddMatrix:
+ { // port, no query, with matrix
+ char sTemp[10];
+ url = _scheme + "://" + _host + ":";
+ sprintf(sTemp, "%d", _port);
+ url += sTemp;
+ url += "/" + _path + ";" + _matrix;
+ break;
+ }
+ }
+ }
+
+ // get path w/query or matrix
+ void getCompletePathString(std::string& p)
+ {
+ // schemeExtra= :// = 3
+ // portExtra = :xxxxx = 6
+ // just in case extra = 32
+ size_t iLen = _path.size() + _query.size() + _matrix.size() + 3 + 6 +
32;
+ p.reserve(iLen);
+
+ int bitField=0;
+ const int bitAddQuery = 1 << 1;
+ const int bitAddMatrix = 1 << 2;
+ if (_query.size() != 0) bitField |= bitAddQuery;
+ if (_matrix.size() != 0) bitField |= bitAddMatrix;
+
+ switch (bitField) {
--- End diff --
Can this be unified with the previous method, rather than duplicated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
