Phil Sorber created TS-4779:
-------------------------------

             Summary: Remove SET_CLOSE_ON_EXEC #ifdef's from socket code.
                 Key: TS-4779
                 URL: https://issues.apache.org/jira/browse/TS-4779
             Project: Traffic Server
          Issue Type: Task
          Components: Network
            Reporter: Phil Sorber


This appears to be set nowhere, and so effectively disables CLOEXEC. 
[[email protected]] suggests we remove just the #ifdef's and thereby enable 
CLOEXEC. I agree with this approach, but it is a change in behavior.

{noformat}
$ grep -ir CLOSE_ON_EXEC
iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to