[ 
https://issues.apache.org/jira/browse/TS-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Peach updated TS-4792:
----------------------------
    Description: 
Since TS-4725, {{HttpTransact::try_to_expand_host_name}} doesn't do much. We 
should remove it and simplify the call sites.

[~zwoop] sez:
{noformat}
Be careful when eliminating try_to_expand_host_name(), I recently discovered 
that this function also deals with DNS failures in parent selection. I'm +1 on 
removing (or renaming) this method, but it can't just be blindly removed.
{noformat}

  was:
Since TS-4725, {{HttpTransact::try_to_expand_host_name}} doesn't do much. We 
should remove it and simplify the call sites.

@zwoop sez:
{noformat}
Be careful when eliminating try_to_expand_host_name(), I recently discovered 
that this function also deals with DNS failures in parent selection. I'm +1 on 
removing (or renaming) this method, but it can't just be blindly removed.
{noformat}


> Remove HttpTransact::try_to_expand_host_name.
> ---------------------------------------------
>
>                 Key: TS-4792
>                 URL: https://issues.apache.org/jira/browse/TS-4792
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: James Peach
>
> Since TS-4725, {{HttpTransact::try_to_expand_host_name}} doesn't do much. We 
> should remove it and simplify the call sites.
> [~zwoop] sez:
> {noformat}
> Be careful when eliminating try_to_expand_host_name(), I recently discovered 
> that this function also deals with DNS failures in parent selection. I'm +1 
> on removing (or renaming) this method, but it can't just be blindly removed.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to