[
https://issues.apache.org/jira/browse/TS-4784?focusedWorklogId=27303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27303
]
ASF GitHub Bot logged work on TS-4784:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/16 21:36
Start Date: 26/Aug/16 21:36
Worklog Time Spent: 10m
Work Description: GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/935
TS-4784: CID 1022032 - Check return value on TSTextLogObjectCreate().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver ts-4784
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/935.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #935
----
commit f1bc5a24082cea7d9983617949cc15bbd09313c7
Author: Phil Sorber <[email protected]>
Date: 2016-08-26T21:35:47Z
TS-4784: CID 1022032 - Check return value on TSTextLogObjectCreate().
----
Issue Time Tracking
-------------------
Worklog Id: (was: 27303)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1022032: Error handling issues (CHECKED_RETURN)
> /plugins/regex_revalidate/regex_revalidate.c
> --------------------------------------------------------------------------------------------------
>
> Key: TS-4784
> URL: https://issues.apache.org/jira/browse/TS-4784
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Phil Sorber
> Labels: Coverity
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1022032: Error handling issues (CHECKED_RETURN)
> /plugins/regex_revalidate/regex_revalidate.c: 478 in TSPluginInit()
> 472 while ((c = getopt_long(argc, (char *const *)argv, "c:l:",
> longopts, NULL)) != -1) {
> 473 switch (c) {
> 474 case 'c':
> 475 pstate->config_file = TSstrdup(optarg);
> 476 break;
> 477 case 'l':
> CID 1022032: Error handling issues (CHECKED_RETURN)
> Calling "TSTextLogObjectCreate" without checking return value (as is done
> elsewhere 7 out of 8 times).
> 478 TSTextLogObjectCreate(optarg, TS_LOG_MODE_ADD_TIMESTAMP,
> &pstate->log);
> 479 TSTextLogObjectRollingEnabledSet(pstate->log, 1);
> 480 TSTextLogObjectRollingIntervalSecSet(pstate->log,
> LOG_ROLL_INTERVAL);
> 481 TSTextLogObjectRollingOffsetHrSet(pstate->log, LOG_ROLL_OFFSET);
> 482 break;
> 483 default:
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
