[
https://issues.apache.org/jira/browse/TS-4779?focusedWorklogId=27306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27306
]
ASF GitHub Bot logged work on TS-4779:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/16 21:39
Start Date: 26/Aug/16 21:39
Worklog Time Spent: 10m
Work Description: Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/934
Issue Time Tracking
-------------------
Worklog Id: (was: 27306)
Time Spent: 1h 20m (was: 1h 10m)
> Remove SET_CLOSE_ON_EXEC #ifdef's from socket code.
> ---------------------------------------------------
>
> Key: TS-4779
> URL: https://issues.apache.org/jira/browse/TS-4779
> Project: Traffic Server
> Issue Type: Task
> Components: Network
> Reporter: Phil Sorber
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This appears to be set nowhere, and so effectively disables CLOEXEC.
> [[email protected]] suggests we remove just the #ifdef's and thereby enable
> CLOEXEC. I agree with this approach, but it is a change in behavior.
> {noformat}
> $ grep -ir CLOSE_ON_EXEC
> iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
