Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
I don't think this is the right approach.
First, ``read_signal_error`` and ``write_signal_error`` don't need to be
made non-static since you already have
``UnixNetVConnection::readSignalError()``.
Second, the ``err`` argument to ``read_signal_error`` is supposed to be an
``errno``, but you are passing and eventio bitmask. That's not really what is
supposed to happen here.
Third, the logic in ``NetHandler::mainNetEvent`` is now weird. There is a
subsequent check for ``get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)``,
but the error case would never be true now.
Finally, does this change mean that ``VC_EVENT_EOS`` is now delivered as
``VC_EVENT_ERROR``? The ``EVENTIO_ERROR`` bitmask includes the ``HUP`` event,
which I suspect means that the socket was closed. I think the expectation is
that this would be detected in ``read_from_net``, but now it looks like you
would get an error event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
