[
https://issues.apache.org/jira/browse/TS-4769?focusedWorklogId=28106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28106
]
ASF GitHub Bot logged work on TS-4769:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/16 08:42
Start Date: 05/Sep/16 08:42
Worklog Time Spent: 10m
Work Description: GitHub user biilmann opened a pull request:
https://github.com/apache/trafficserver/pull/964
Fix SSLCreateServerContext always returning null
This fixes TS-4769 but would like @shinrich's thoughts on whether this
makes sense semantically.
The fix is to let the `SSLCreateServerContext` set the
`SSLCertContext::OPT_TUNNEL` option on the `sslMultCertSettings` object, which
in this case makes the call to `SSLInitServerContext` do the right thing and
not look for any certificates in the multicert settings object and just
initialize the context.
What I'm not certain of is whether using OPT_TUNNEL for this could cause
any confusion in the future...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/biilmann/trafficserver
fix-ssl-create-server-context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/964.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #964
----
commit d0850c662fd192518aab2ec96332c4ab9cdb1ea5
Author: Mathias Biilmann Christensen <[email protected]>
Date: 2016-09-05T08:34:05Z
Fix SSLCreateServerContext always returning null
----
Issue Time Tracking
-------------------
Worklog Id: (was: 28106)
Time Spent: 10m
Remaining Estimate: 0h
> TSSslServerContextCreate always returns null
> --------------------------------------------
>
> Key: TS-4769
> URL: https://issues.apache.org/jira/browse/TS-4769
> Project: Traffic Server
> Issue Type: Bug
> Components: SSL, TS API
> Reporter: Mathias Biilmann Christensen
> Assignee: Susan Hinrichs
> Priority: Blocker
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The change to SSLInitServerContext in
> https://github.com/apache/trafficserver/pull/810 breaks the
> TSSslServerContextCreate API method, since this one calls
> TSSslServerContextCreate with an empty sslMultCertSettings.
> This means plugins can't create a fresh SSL context and set the certificates
> themselves.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
